Repository navigation
docs: installation: source: gate new build options to v5.1.3 - #2738
Conversation
Neither FLB_PROTOBUF_ENCODER nor FLB_OUT_ARVANCLOUD_CLOUDLOGS exists in
v5.1.2 or any earlier tag. Both ship in v5.1.3. CMake accepts unknown
-D definitions silently, so passing either on a current release fails
without any diagnostic.
- Annotate the FLB_PROTOBUF_ENCODER build options row and scope the
note that follows the table.
- Scope FLB_OUT_ARVANCLOUD_CLOUDLOGS in the sentence introducing the
output plugins table.
Both tables are hand aligned at fixed row widths. The protobuf
annotation is absorbed from that row's existing cell padding, so the
build options table stays at 186 characters per row. The ArvanCloud
row has only 16 characters of padding, so it is scoped in prose rather
than re-padding roughly 90 rows.
Refs fluent#2727
Signed-off-by: Eric D. Schabell <eric@schabell.org>
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe build and install guide now states that ChangesBuild option availability
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~4 minutes Change: Other Merge Risk: ⚪ Minimal · up to The notes steer v5.1.2 users away from options absent in that release. Later-version support was not independently confirmed, but no contradictory evidence or concrete user-facing failure was established; no demonstrated merge-blocking risk remains. Architecture SummaryArchitecture risk: 🔵 Low · up to The change affects 1 system. Changed systems: Architecture concerns Review detailsSystems and components
Before / after behavior
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@patrick-stephens ready for review! |
2 participants
Neither FLB_PROTOBUF_ENCODER nor FLB_OUT_ARVANCLOUD_CLOUDLOGS exists in
v5.1.2 or any earlier tag. Both ship in v5.1.3. CMake accepts unknown
-D definitions silently, so passing either on a current release fails
without any diagnostic.
note that follows the table.
output plugins table.
Both tables are hand aligned at fixed row widths. The protobuf
annotation is absorbed from that row's existing cell padding, so the
build options table stays at 186 characters per row. The ArvanCloud
row has only 16 characters of padding, so it is scoped in prose rather
than re-padding roughly 90 rows.
Refs #2727